Re: [PATCH 0/7] Silence even more W=2 warnings
From: Jeff Kirsher
Date: Mon Sep 22 2014 - 15:45:01 EST
On Mon, 2014-09-22 at 21:21 +0200, Borislav Petkov wrote:
> On Mon, Sep 22, 2014 at 06:59:23PM +0000, Rustad, Mark D wrote:
> > It is helpful for using the warnings to look for problems or even
> just risks.
> That's what W= builds are for.
> > Right now the number of warnings generated when using W=2 simply
> > people to never use W=2.
> I showed you how to use W=2 and 3 for that matter - pipe the output
> a file and grep away.
Not sure you showed us, since that is how everyone has had to do to
actual find W= builds useful. Just because that is how we HAVE to do it
now, does not make it the best way. Here is a thought, we don't we fix
the potential issues, so that W= builds do not generate over 100,000
Mark did this approach because it would either spur the conversation
that this is a good idea OR let's fix the root problem. Instead it
sounds like your response is "life sucks, get over it" and put your head
back in the sand to ignore the problem.
> > That severely limits the value of a useful tool. A checkpatch
> > doesn't mean to never do that, just that it needs a critical look
> > justification. That is certainly true of every patch I made that
> > those macros.
> Sorry, if you need to shut up the compiler by adding code with the
> purpose to not issue a warning for otherwise perfectly fine code, then
> something's wrong with the whole endeavor in the first place.
> There's a reason W= warnings are disabled in the default build.
Description: This is a digitally signed message part