Re: [PATCH] kvm: Fix page ageing bugs

[Rik van Riel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/22/2014 03:57 PM, Andres Lagar-Cavilla wrote:
> 1. We were calling clear_flush_young_notify in unmap_one, but we
> are within an mmu notifier invalidate range scope. The spte exists
> no more (due to range_start) and the accessed bit info has already
> been propagated (due to kvm_pfn_set_accessed). Simply call 
> clear_flush_young.
> 
> 2. We clear_flush_young on a primary MMU PMD, but this may be
> mapped as a collection of PTEs by the secondary MMU (e.g. during
> log-dirty). This required expanding the interface of the
> clear_flush_young mmu notifier, so a lot of code has been trivially
> touched.
> 
> 3. In the absence of shadow_accessed_mask (e.g. EPT A bit), we
> emulate the access bit by blowing the spte. This requires proper
> synchronizing with MMU notifier consumers, like every other removal
> of spte's does.

Acked-by: Rik van Riel <riel@xxxxxxxxxx>


- -- 
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUIIQiAAoJEM553pKExN6DWeoH/RpkYF1QCxnbxgZhnioaWjyu
Rp/kN6Rck6Eu3k/yRI6k+8IhgUJWkVhSXybTIDl1X6aVGgYwhaeOv2zPPfshfM6h
ABE3pLFjs2qtdotZXFSvZ4mNwbQE73YHphAbmFUBSdm2Oz1bj6Qfq+KYFdM+aQd7
UYIFgtdGg/tyLMqE25J7pAnSDRR5GKmAKLvkFjN3Q8O4ynD3rExH1yTMLtQbyKvb
oadSzaQLBOkLDAj3rpiOTl52B2tlQS+cxWqEfzA/AXOK8TkllDKIQT5BeRXV5O1c
/WsZmusiA6KYgjLxnL0K9XJpgpOQ5unYAFyIGgYmKiaN6PQsd+pGM5GDnOWGorE=
=dftO
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/