Re: [PATCH 0/3 v2] drivers/bus: Freescale Management Complex bus driver patch series

[Kim Phillips]

On Mon, 22 Sep 2014 12:59:21 -0500
Yoder Stuart-B08248 <stuart.yoder@xxxxxxxxxxxxx> wrote:

> > From: Kim Phillips [mailto:kim.phillips@xxxxxxxxxxxxx]
> > Sent: Monday, September 22, 2014 11:53 AM
> > 
> > On Fri, 19 Sep 2014 17:49:38 -0500
> > "J. German Rivera" <German.Rivera@xxxxxxxxxxxxx> wrote:
> > 
> > > CHANGE HISTORY
> > >
> > > Issues pending resolution not addressed by v2:
> > > - What to do with Doxygen comments in patch 1
> > 
> > It's clear they should be removed.
> > 
> > > - Whether to move or not FSL-specific header files added in include/linux,
> > >   by this patch series, to another location
> > 
> > there wasn't a valid objection against moving them under fsl/ and
> > changing them to use dashes instead of underscores, was there?
> 
> There was no objection, but here is the observation.  The current
> convention seems to be that under include/linux are 'subsystem'
> types--
>    include/linux/mmc
>    include/linux/spi
>    include/linux/raid
>     etc
> 
> There is no other "company" that has an include/linux/[company-name] that I can
> see.  Freescale seems to be the only one.   And there is only a single driver
> in there.  So it looks like a complete anomaly.
> 
> Why is that?
> 
> I guess we could try moving our stuff to incluce/linux/fsl and see if there is
> any negative feedback on it.

these two commits:

commit 9a32299 "powerpc, dma: move bestcomm driver from
arch/powerpc/sysdev to drivers/dma"

commit 3946860 "mxs-dma : move the mxs dma.h to a more common place"

create/update files in include/linux/fsl for the same reason as this
patchseries wants, i.e., in order to support multiple drivers
including the files, and in an arch- (and mach-) independent manner.

hth,

Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/