Re: [PATCH] ath: change logging functions to return void

From: Kalle Valo
Date: Tue Sep 23 2014 - 00:21:08 EST


Joe Perches <joe@xxxxxxxxxxx> writes:

> The return values are not used by callers of these functions
> so change the functions to return void.
>
> Other miscellanea:
>
> o add __printf verification to wil6210 logging functions
> No format/argument mismatches found
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> This change is associated to a desire to eventually
> change printk to return void.
>
> drivers/net/wireless/ath/ath10k/debug.c | 18 +++++-------------
> drivers/net/wireless/ath/ath10k/debug.h | 6 +++---
> drivers/net/wireless/ath/ath6kl/common.h | 2 +-
> drivers/net/wireless/ath/ath6kl/debug.c | 28 ++++++++--------------------
> drivers/net/wireless/ath/ath6kl/debug.h | 13 ++++++-------

For ath6kl and ath10k:

Acked-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx>

> drivers/net/wireless/ath/wil6210/debug.c | 14 ++++----------
> drivers/net/wireless/ath/wil6210/wil6210.h | 7 +++++--
> 7 files changed, 32 insertions(+), 56 deletions(-)

John, as this patch also contains a wil6210 change how do you want to
handle this?

--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/