Re: [PATCH v7 06/10] rtc: at91sam9: rework the Kconfig description
From: Johan Hovold
Date: Tue Sep 23 2014 - 06:42:04 EST
On Tue, Sep 23, 2014 at 12:08:47PM +0200, Nicolas Ferre wrote:
> On 23/09/2014 11:38, Boris BREZILLON :
> > Remove all references to AT91CAP9 SoC which has been removed.
> > Rework the help message to remove any specific references to AT91SAM9 SoCs.
> > Signed-off-by: Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> > ---
> > drivers/rtc/Kconfig | 17 +++++++++--------
> > 1 file changed, 9 insertions(+), 8 deletions(-)
> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> > index 7d76da8..455f2c3 100644
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -1079,17 +1079,18 @@ config RTC_DRV_AT91RM9200
> > this is powered by the backup power supply.
> > config RTC_DRV_AT91SAM9
> > - tristate "AT91SAM9x/AT91CAP9 RTT as RTC"
> > + tristate "AT91SAM9 RTT as RTC"
> > depends on ARCH_AT91 && !(ARCH_AT91RM9200 || ARCH_AT91X40)
> > select MFD_SYSCON
> > help
> > - RTC driver for the Atmel AT91SAM9x and AT91CAP9 internal RTT
> > - (Real Time Timer). These timers are powered by the backup power
> > - supply (such as a small coin cell battery), but do not need to
> > - be used as RTCs.
> > -
> > - (On AT91SAM9rl and AT91SAM9G45 chips you probably want to use the
> > - dedicated RTC module and leave the RTT available for other uses.)
> > + Some AT91SAM9 SoCs provide an RTT (Real Time Timer) block which
> > + can be used as an RTC thanks to the backup power supply (e.g. a
> > + small coin cell battery) which keeps this block and the GPBR
> > + (General Purpose Backup Registers) block powered when the device
> > + is shutdown.
> > + Some AT91SAM9 SoCs provide a real RTC block, on those ones you'd
> > + probably want to use the real RTC block instead of the RTT as an
> > + RTT driver.
> You mean:
> "instead of the RTT as an RTC"
Boris, perhaps you should also update the Kconfig entries for
RTC_DRV_AT91SAM9_RTT and RTC_DRV_AT91SAM9_GPBR to clarify that they are
only used for legacy booting (and otherwise have no effect)?
> With that, good description: thanks!
> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> So, now we can think of what to do with the series:
> - Johan, do you want to "Ack" it?
I had one comment to the slow-clock patch, but feel free to add my
Acked-by: Johan Hovold <johan@xxxxxxxxxx>
to the whole series.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/