Re: [PATCH v7 08/10] rtc: at91sam9: use clk API instead of relying on AT91_SLOW_CLOCK

From: Boris BREZILLON
Date: Tue Sep 23 2014 - 07:09:03 EST


On Tue, 23 Sep 2014 12:33:26 +0200
Johan Hovold <johan@xxxxxxxxxx> wrote:

> On Tue, Sep 23, 2014 at 11:38:48AM +0200, Boris BREZILLON wrote:
>
> > @@ -328,6 +328,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
> > struct sam9_rtc *rtc;
> > int ret, irq;
> > u32 mr;
> > + unsigned int sclk_rate;
> >
> > irq = platform_get_irq(pdev, 0);
> > if (irq < 0) {
> > @@ -385,11 +386,27 @@ static int at91_rtc_probe(struct platform_device *pdev)
> > return -ENOMEM;
> > }
> >
> > + rtc->sclk = devm_clk_get(&pdev->dev, NULL);
> > + if (IS_ERR(rtc->sclk))
> > + return PTR_ERR(rtc->sclk);
> > +
> > + sclk_rate = clk_get_rate(rtc->sclk);
> > + if (!sclk_rate || sclk_rate > AT91_RTT_RTTRST) {
>
> You probably meant AT91_RTT_RTPRES here.

Yes, that's what I meant.
Nice catch!

Thanks,

Boris


--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/