Re: [STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional

[Peter Griffin]

Hi Srini,

On Mon, 22 Sep 2014, Srinivas Kandagatla wrote:

> This patch fixes a compilation error while building with the
> random kernel configuration.
> 
> drivers/media/rc/st_rc.c: In function 'st_rc_probe':
> drivers/media/rc/st_rc.c:281:2: error: implicit declaration of
> function 'reset_control_get' [-Werror=implicit-function-declaration]
>   rc_dev->rstc = reset_control_get(dev, NULL);
> 
> drivers/media/rc/st_rc.c:281:15: warning: assignment makes pointer
> from integer without a cast [enabled by default]
>   rc_dev->rstc = reset_control_get(dev, NULL);

Is managing the reset line actually optional though? I can't test atm as I don't have
access to my board, but quite often if the IP's aren't taken out of reset reads / writes
to the perhpiheral will hang the SoC.

If managing the reset line isn't optional then I think the correct fix is to add
depends on RESET_CONTROLLER in the kconfig.

This will then do the right thing for randconfig builds as well.

regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/