Re: [GIT PULL] x86 fixes

[Ingo Molnar]

* Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote:

> @@ -1394,10 +1394,7 @@ struct boot_params *efi_main(struct efi_config *c,
>  
>  	setup_graphics(boot_params);
>  
> -	status = setup_efi_pci(boot_params);
> -	if (status != EFI_SUCCESS) {
> -		efi_printk(sys_table, "setup_efi_pci() failed!\n");
> -	}
> +	setup_efi_pci(boot_params);
>  
>  	status = efi_call_early(allocate_pool, EFI_LOADER_DATA,
>  				sizeof(*gdt), (void **)&gdt);


So 'status' is unused - either use it for a less threatening 
message, or remove the return code from the function and document 
that failure is an option?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/