Re: [RFC PATCH] usb: core: log more general message on malformed LANGID descriptor

[Greg Kroah-Hartman]

On Tue, Sep 23, 2014 at 10:28:49PM +0000, Scot Doyle wrote:
> I'd like to change this error message:
> [    3.325837] usb 1-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409
> 
> into an error message followed by a debug message:
> [    3.324726] usb 1-4: malformed string descriptor; unknown language, defaulting to English
> [    3.327514] usb 1-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409
> 
> in order to communicate more information from the log itself. Are there 
> any problems with this approach? Would it be better to put all the 
> information on a single line? Something else?

How about just one line, why two?

And something like "device not implementing langid specifier, defaulting
to English", but cleaned up to sound a bit better?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/