Re: [PATCH v4 10/10] blk-mq: support per-distpatch_queue flush machinery

[Christoph Hellwig]

> +struct blk_flush_queue *blk_alloc_flush_queue(struct request_queue *q,
> +		struct blk_mq_hw_ctx *hctx, int cmd_size)

I still think this should pass in the numa node instead of the hctx, and
allow node-local allocation for the old code as well.  As mentioned earlier
initializing mq_flush_lock for the !mq case is harmless. 


We also should document it where cleary somewhere that for devices that
have flushes enabled ->init_request can be called for more requests than
the queue depth, as drivers might allocate some sort of pool for them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/