Re: FIX Me in pgtable.h

From: nick
Date: Wed Sep 24 2014 - 07:38:26 EST




On 14-09-23 11:21 PM, Laura Abbott wrote:
> On 9/23/2014 6:04 AM, nick wrote:
>> Greetings Arm Maintainers,
>> I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct
>> value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect
>> and should be changed.
>> Thanks,
>> Nick
>>
>
> It's not clear to me how valuable fixing kern_addr_valid would actually
> be for arm. It seems to be used in exactly one place, fs/proc/kcore.c
> and the associated Kconfig is explicitly marked if !ARM. Nearly all
> other archs minus x86, arm64 and sparc are in the same boat as well.
>
> Thanks,
> Laura
>
Laura,
Can we remove it then as it seems that it's not needed at all.
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/