Re: [PATCH v4 08/10] block: introduce 'blk_mq_ctx' parameter to blk_get_flush_queue

[Ming Lei]

On Wed, Sep 24, 2014 at 6:21 PM, Christoph Hellwig <hch@xxxxxx> wrote:
> On Mon, Sep 15, 2014 at 09:11:12PM +0800, Ming Lei wrote:
>> This patch adds 'blk_mq_ctx' parameter to blk_get_flush_queue(),
>> so that this function can find the corresponding blk_flush_queue
>> bound with current mq context since the flush queue will become
>> per hw-queue.
>>
>> For legacy queue, the parameter can be simply 'NULL'.
>>
>> For multiqueue case, the parameter should be set as the context
>> from which the related request is originated. With this context
>> info, the hw queue and related flush queue can be found easily.
>
> I think this should be merged into the patch introducing
> blk_get_flush_queue.

The 'blk_mq_ctx' parameter should be treated carefully for
the function, that is why the patch isn't merged to previous
one, and patch 5 is big enough.

Again, small patch is easier for review, and we should try to
do one thing in one patch.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/