Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error

[Alan Stern]

On Mon, 22 Sep 2014, Michal Simek wrote:

> Hi Alan and Greg,
> 
> On 09/20/2014 06:19 AM, Chen Gang wrote:
> > Hello Maintainers:
> > 
> > Please help check this patch, when you have time.
> > 
> > Thanks.
> > 
> > On 09/08/2014 01:20 PM, Michal Simek wrote:
> >> On 09/03/2014 05:50 PM, Chen Gang wrote:
> >>> Need include it for irq_of_parse_and_map(), the related error with
> >>> allmodconfig under microblaze:
> >>>
> >>>   drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’:
> >>>   drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration]
> >>>     irq = irq_of_parse_and_map(dn, 0);
> >>>     ^
> >>>
> >>> Signed-off-by: Chen Gang <gang.chen.5i5j@xxxxxxxxx>
> >>> ---
> >>>  drivers/usb/host/ehci-xilinx-of.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> >>> index fe57710..a232836 100644
> >>> --- a/drivers/usb/host/ehci-xilinx-of.c
> >>> +++ b/drivers/usb/host/ehci-xilinx-of.c
> >>> @@ -31,6 +31,7 @@
> >>>  #include <linux/of.h>
> >>>  #include <linux/of_platform.h>
> >>>  #include <linux/of_address.h>
> >>> +#include <linux/of_irq.h>
> >>>  
> >>>  /**
> >>>   * ehci_xilinx_port_handed_over - hand the port out if failed to enable it
> >>>
> >>
> >> Acked-by: Michal Simek <monstr@xxxxxxxxx>
> 
> Alan: Can you please add this patch to your queue?
> Greg: If Alan is not maintaining this part of kernel, is this patch in your queue?
> 
> I have also not a problem to add this patch through my microblaze tree
> but I think it will be much better to use any USB tree.

Greg should be able to accept a trivial patch like this one directly.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/