Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

[Shuah Khan]

On 09/24/2014 10:30 AM, Steven Rostedt wrote:
> On Wed, 24 Sep 2014 10:22:12 -0600
> Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
> 
> 
>> One simple approach is to have the user install the required tools
>> for the test. Indicate what is needed and fail the test with
>> appropriate message with xskip. This is what I have in mind for
>> tests that can't be run because of a missing config. The same can
>> be extended to external tools that the test depends on.
> 
> Should I hold off adding my tests until we have all this in place. Or
> should I just push my tests with simply passing if the config isn't
> supported for now and add it later?
> 
> I wont add any of the tests that require other tools besides echo, grep
> and cat.
> 

Please go ahead and get them in. The framework might have to wait
until 3.19, so there is no need to have it gate test development.
We can evolve them as we go. If tests require special, it means that
they aren't suitable for certain envs such as qemu boot with busybox.
There is a plan to add test targets to cover such cases.

I would recommend at least printing a message saying what you are
missing if you find something missing.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/