Re: [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC

[Michal Simek]

On 09/24/2014 06:18 PM, SÃren Brinkmann wrote:
> On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
>> Add missing reference for ADC node.
>>
>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
>> ---
>>
>>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index 772381fe07bb..fc90f47f9c03 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -64,7 +64,7 @@
>>  		interrupt-parent = <&intc>;
>>  		ranges;
>>
>> -		adc@f8007100 {
>> +		adc: adc@f8007100 {
> I think we enumerated all labels. I.e. 'adc0' is probably better.

I was thinking about it and the reason I didn't use that adc0 was
that it is unique and it is just one in PS. Maybe there could be another adc in PL
but it will be probably automated not to use adc key world.
For PL part names was depending on user description.

Anyway logic was not to use enumerated label for unique IPs.

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/