Re: [PATCH v7 1/5] PM / Runtime: Add getter for quering the IRQ safe option

[Pavel Machek]

On Wed 2014-09-24 15:50:08, Krzysztof Kozlowski wrote:
> Add a simple getter pm_runtime_is_irq_safe() for quering whether runtime
> PM IRQ safe was set or not.
> 
> Various bus drivers implementing runtime PM may use choose to suspend
> differently based on IRQ safeness status of child driver (e.g. do not
> unprepare the clock if IRQ safe is not set).
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Are you sure this is good interface?

"Tell me if another function works this or that way".

That's certainly not traditional interface, and it seems dangerous to
me. Callbacks now have different semantic requirements based on value
of some flag...

Would it be possible to have two sets of callbacks, one irq safe and
one not?
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/