Re: [PATCH] vfs: fix linkat error for unprivileged AT_EMPTY_PATH

[Al Viro]

On Wed, Sep 24, 2014 at 05:25:23PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@xxxxxxx>
> 
> Return proper error value for linkat(..., AT_EMPTY_PATH) without enough
> privileges.
> 
> I guess ENOENT was used here, because without AT_EMPTY_PATH that's what
> we'd return for an empty path.  But it is wrong for AT_EMPTY_PATH, since we
> might not even be passing an empty path, we are simply complaining about
> lack of privs for which EPERM is the proper error.

Umm...  Are you sure that nothing in userland is checking for that
return value?  I agree that EPERM would make more sense, but...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/