Re: [PATCH 08/11] perf/x86/intel: Add Intel Cache QoS Monitoring support

[Andi Kleen]

On Wed, Sep 24, 2014 at 09:27:39PM +0100, Matt Fleming wrote:
> > > +static int __init intel_cqm_init(void)
> > > +{
> > > +	int i, cpu, ret;
> > > +
> > > +	if (!cpu_has(&boot_cpu_data, X86_FEATURE_CQM_OCCUP_LLC))
> > > +		return -ENODEV;
> > 
> > This should use cpufeature.h
>  
> What? Please be more explicit.

Using x86_match_cpu and friends, then it would work for module
auto loading too.

> > But in fact what good is the test then if you only
> > every likely check cpu #0?
> 
> We don't, we check every online cpu, not just cpu 0.

There are no other cpus online at this point?

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/