Re: [PATCH 3/3] staging: dgap: use dgap_release_remap() in dgap_cleanup_board()

[DaeSeok Youn]

Hi,

2014-09-24 18:45 GMT+09:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote:
>>  static void dgap_release_remap(struct board_t *brd)
>>  {
>> -     release_mem_region(brd->membase, 0x200000);
>> -     release_mem_region(brd->membase + PCI_IO_OFFSET, 0x200000);
>> -     iounmap(brd->re_map_membase);
>> -     iounmap(brd->re_map_port);
>> +     if (brd->re_map_membase) {
>
> I hate this if conditions.  Let's not complicate dgap_release_remap(),
> let's fix the callers instead.  Especially dgap_init_module() is a
> totally sucky function with bad unwinding.
ok. then,
   if (brd->re_map_membase && brd->re_map_port)
        dgap_release_remap(brd);

right?
>
> Let's not apply this patch.
oh.. this patch was already applied to staging tree.
I will make different patch for this.

thanks.

regards,
Daeseok Youn.
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/