Re: [PATCH v4 01/10] tools/perf: support parsing parameterized events

[Jiri Olsa]

On Wed, Sep 24, 2014 at 12:27:15PM -0700, Sukadev Bhattiprolu wrote:
> From: Cody P Schafer <cody@xxxxxxxxxxxxxxxxxx>
> 
> Enable event specification like:
> 
> 	pmu/event_name,param1=0x1,param2=0x4/
> 
> Assuming that
> 
> 	/sys/bus/event_source/devices/pmu/events/event_name
> 
> Contains something like
> 
> 	param2=foo,bar=1,param1=baz

hum, so what happened to the '?' ... AFAIU from out last discussion,
you wanted to mark terms which are mandatory and user must provide
values for them.. and I thought the decision was to have following
alias record:

  $ cat /sys/bus/event_source/devices/pmu/events/event_name
  param2=?,bar=1,param1=?

while perf would scream if any of param1/2 wasnt filled like for:
  pmu/event_name,param1=0x1/


thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/