Re: [PATCH] usb: core: log higher level message on malformed LANGID descriptor

From: Joe Perches
Date: Thu Sep 25 2014 - 10:31:04 EST


On Thu, 2014-09-25 at 13:56 +0000, Scot Doyle wrote:
> Commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0
> USB: fix LANGID=0 regression

trivia:

> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
[]
> @@ -770,9 +770,7 @@ static int usb_get_langid(struct usb_device *dev, unsigned char *tbuf)
> dev->string_langid = 0x0409;
> dev->have_langid = 1;
> dev_err(&dev->dev,
> - "string descriptor 0 malformed (err = %d), "
> - "defaulting to 0x%04x\n",
> - err, dev->string_langid);
> + "language id specifier not provided by device, defaulting to English");

missing '\n' format termination.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/