Re: [PATCH v3 13/13] ARM: shmobile: r8a7740 dtsi: Add preliminary PM QoS device latencies

From: Geert Uytterhoeven
Date: Fri Sep 26 2014 - 04:17:00 EST

On Thu, Sep 25, 2014 at 6:28 PM, Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
> diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
> index ed0adeb61a1ad8ec..713170442b7bd4b2 100644
> --- a/arch/arm/boot/dts/r8a7740.dtsi
> +++ b/arch/arm/boot/dts/r8a7740.dtsi

> @@ -409,6 +509,10 @@
> reg = <0xe6150000 0x10000>;
> clocks = <&extal1_clk>, <&extalr_clk>;
> power-domains = <&pd_c5>;
> + stop-latency = <250000>;
> + start-latency = <250000>;
> + save-state-latency = <250000>;
> + restore-state-latency = <250000>;
> #clock-cells = <1>;
> clock-output-names = "system", "pllc0", "pllc1",
> "pllc2", "r",
> @@ -424,6 +528,10 @@
> reg = <0xe6150080 4>;
> clocks = <&pllc1_div2_clk>;
> power-domains = <&pd_c5>;
> + stop-latency = <250000>;
> + start-latency = <250000>;
> + save-state-latency = <250000>;
> + restore-state-latency = <250000>;
> #clock-cells = <0>;
> clock-output-names = "sub";
> };
> @@ -433,6 +541,10 @@
> compatible = "fixed-factor-clock";
> clocks = <&cpg_clocks R8A7740_CLK_PLLC1>;
> power-domains = <&pd_c5>;
> + stop-latency = <250000>;
> + start-latency = <250000>;
> + save-state-latency = <250000>;
> + restore-state-latency = <250000>;
> #clock-cells = <0>;
> clock-div = <2>;
> clock-mult = <1>;
> @@ -442,6 +554,10 @@
> compatible = "fixed-factor-clock";
> clocks = <&extal1_clk>;
> power-domains = <&pd_c5>;
> + stop-latency = <250000>;
> + start-latency = <250000>;
> + save-state-latency = <250000>;
> + restore-state-latency = <250000>;
> #clock-cells = <0>;
> clock-div = <2>;
> clock-mult = <1>;
> @@ -454,6 +570,10 @@
> reg = <0xe6150080 4>;
> clocks = <&sub_clk>, <&sub_clk>;
> power-domains = <&pd_c5>;
> + stop-latency = <250000>;
> + start-latency = <250000>;
> + save-state-latency = <250000>;
> + restore-state-latency = <250000>;
> #clock-cells = <1>;
> renesas,clock-indices = <
> R8A7740_CLK_SUBCK R8A7740_CLK_SUBCK2
> @@ -470,6 +590,10 @@
> <&sub_clk>, <&sub_clk>,
> <&cpg_clocks R8A7740_CLK_B>;
> power-domains = <&pd_c5>;
> + stop-latency = <250000>;
> + start-latency = <250000>;
> + save-state-latency = <250000>;
> + restore-state-latency = <250000>;
> #clock-cells = <1>;
> renesas,clock-indices = <
> R8A7740_CLK_CEU21 R8A7740_CLK_CEU20 R8A7740_CLK_TMU0
> @@ -492,6 +616,10 @@
> <&sub_clk>, <&sub_clk>, <&sub_clk>,
> <&sub_clk>;
> power-domains = <&pd_c5>;
> + stop-latency = <250000>;
> + start-latency = <250000>;
> + save-state-latency = <250000>;
> + restore-state-latency = <250000>;
> #clock-cells = <1>;
> renesas,clock-indices = <
> R8A7740_CLK_SCIFA6 R8A7740_CLK_INTCA
> @@ -522,6 +650,10 @@
> <&cpg_clocks R8A7740_CLK_HP>,
> <&cpg_clocks R8A7740_CLK_HP>;
> power-domains = <&pd_c5>;
> + stop-latency = <250000>;
> + start-latency = <250000>;
> + save-state-latency = <250000>;
> + restore-state-latency = <250000>;
> #clock-cells = <1>;
> renesas,clock-indices = <
> R8A7740_CLK_CMT1 R8A7740_CLK_FSI R8A7740_CLK_IIC1
> @@ -540,6 +672,10 @@
> <&cpg_clocks R8A7740_CLK_HP>,
> <&cpg_clocks R8A7740_CLK_HP>;
> power-domains = <&pd_c5>;
> + stop-latency = <250000>;
> + start-latency = <250000>;
> + save-state-latency = <250000>;
> + restore-state-latency = <250000>;
> #clock-cells = <1>;
> renesas,clock-indices = <
> R8A7740_CLK_USBH R8A7740_CLK_SDHI2

Same here, as there should be no power-domains properties in the clocks
nodes, there should be no latencies specified neither.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/