Re: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs

[Russell King - ARM Linux]

On Fri, Sep 26, 2014 at 08:39:04AM +0000, Li.Xiubo@xxxxxxxxxxxxx wrote:
> [...]
> > On Fri, Sep 26, 2014 at 05:30:40AM +0000, Li.Xiubo@xxxxxxxxxxxxx wrote:
> > > Hi Russell,
> > >
> > > I'd like to know the status of this patch.
> > >
> > > Our Platforms depend on it.
> > 
> > I'm not applying it.  This option should not be exposed for general
> > use.  The usage pattern is clear from the existing users - propose
> > an alternative default value for your platform rather than making it
> > a user visible tweakable option.
> > 
> 
> Okay.
> 
> Something like :
> ++++++++++
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 1ad6fb6..5729a2c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1802,7 +1802,7 @@ source "mm/Kconfig"
>  config FORCE_MAX_ZONEORDER
>         int "Maximum zone order" if ARCH_SHMOBILE
>         range 11 64 if ARCH_SHMOBILE
> -       default "12" if SOC_AM33XX
> +       default "12" if SOC_AM33XX || SOC_LS1021A
>         default "9" if SA1111
>         default "11"
>         help
> ----------
> 
> Is okay ?

It's much better than exposing the option, but I'd like this patch to
appear as a properly submitted change (including a change log which
provides the reason why this is necessary.)

Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/