Re: [PATCH v3 01/29] asm-generic: add generic futex for !CONFIG_SMP

[Tobias Klauser]

On 2014-09-24 at 13:10:00 +0200, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Wednesday 24 September 2014 18:57:54 Ley Foon Tan wrote:
> > On Wed, Sep 24, 2014 at 6:40 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > > On Wednesday 24 September 2014 18:18:50 Ley Foon Tan wrote:
> > >> On Tue, Sep 23, 2014 at 6:40 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > >> > On Tuesday 23 September 2014 18:20:08 LF.Tan wrote:
> > >> >> Hi Arnd
> > >> >>
> > >> >> Are you okay with this generic futex in asm-generic?
> > >> >>
> > >> >
> > >> > Yes, this looks good. Remind me again who need this, would it make
> > >> > sense to merge this through an architecture-specific tree for
> > >> > whichever architecture can benefit from it?
> > >> What is the common practice for this?
> > >> Do you mean merge with nios2 or other arch, eg m68k?
> > >
> > > I mean do it as part of the nios2 patches.
> > I am okay with this.
> > Do I need to get ACK for all patches in order for nios2 merge into mainline?
> > Thanks.
> > 
> 
> Please add my 'Acked-by: Arnd Bergmann <arnd@xxxxxxxx>' to this patch
> once Thomas is ok with it. I think we had concluded already that it
> was correct when we talked about it last time, but he doesn't seem
> convinced yet so I want to wait for his reply.
> 
> You definitely need an Ack for all patches touching code outside of
> arch/nios2, from the respective maintainers. For the nios2 code,
> having as many acks as you can helps, and I should probably take
> a last look so I can ack the pull request when you send it.

Speaking of the nios2 part: I'm the author of some parts of this code,
but now also reviewed this series (or rather, intend to do so for the
few remaining patches I didn't review yet).

What is the appropriate way to account for this? Is Reviewed-By still OK? I
guess I won't be considered an entirely neutral reviewer ;)

Cheers
Tobias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/