Re: Stupid NVIDIA 3D vgaarb.c patch

From: Aaron Plattner
Date: Fri Sep 26 2014 - 17:08:35 EST


On 09/23/2014 01:29 PM, Benjamin Herrenschmidt wrote:
On Mon, 2014-09-22 at 13:43 -0700, Linus Torvalds wrote:
Adding proper people and mailing lists..

The PCI_CLASS_DISPLAY_VGA test goes back to the very beginning by
BenH, and I have no idea if adding PCI_CLASS_DISPLAY_3D is
appropriate, but hopefully somebody does. The fact that it makes
things work certainly argues fairly convincingly for it, but I want
some backup here.

Dave, BenH?

Christopher(?), can you please also specify which laptop etc. And the
patch itself seems to have come from somebody else, unless you're
Lekensteyn. So we'd want to get the provenance of that too.

Hrm, that sucks. "3D" could mean anything really, we might need an
explicit vendor ID check as well and maybe even device ID ...

If my understanding is correct, the board designers explicitly mark them as "3D controller" when they don't have any outputs connected, specifically so the SBIOS won't choose them as the boot VGA device. Depending on the design, some GPUs on these 3D controller boards don't have a display engine at all, while others still have it in the silicon but leave it disabled at runtime. In either case, VGA should not be routed to them and I don't think they should need to participate in VGA arbitration.

-- Aaron

Ben.

Linus

On Mon, Sep 22, 2014 at 1:28 PM, C BergstrÃm <cbergstrom@xxxxxxxxxxxxx> wrote:
Hi Linus,

I don't know who the original author is and I can have one of the distro
graphics friends review it, but I need this patch below to get NVIDIA
drivers to work (without using any Intel graphics) on my laptop
http://pastebin.com/wpmFi38k

Sorry - I know this is not the proper way to submit a patch, but it's
trivial and I'm not a kernel dev.

Thanks

./C
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/