Re: [PATCH 2/2] arm, fbdev, omap2, LLVMLinux: Remove nested function from omapfb

From: Felipe Balbi
Date: Sat Sep 27 2014 - 12:47:13 EST


On Fri, Sep 26, 2014 at 06:10:53PM -0700, Behan Webster wrote:
> Replace the use of nested functions where a normal function will suffice.
>
> Nested functions are not liked by upstream kernel developers in general. Their
> use breaks the use of clang as a compiler, and doesn't make the code any
> better.
>
> This code now works for both gcc and clang.
>
> Signed-off-by: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>
> Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Felipe Balbi <balbi@xxxxxx>

--
balbi

Attachment: signature.asc
Description: Digital signature