Re: [PATCH] clk: Add PWM clock driver

[Mike Turquette]

Quoting Thierry Reding (2014-09-23 01:51:31)
> On Wed, Sep 10, 2014 at 10:05:17PM +0200, Janusz UÅycki wrote:
> > Hi,
> > 
> > http://patchwork.ozlabs.org/patch/359069/
> > https://lkml.org/lkml/2014/6/12/186
> > 
> > Will the patch ever included to linux-next?
> 
> I've never seen this patch before. From a quick look it doesn't seem
> like it would work as is, but the idea is certainly interesting. If
> somebody decides to continue work on it, please Cc me and the linux-pwm
> mailing list.

I just merged a gpio-controlled clock gate and I'm fine with a PWM clock
output.

Janusz, how are you testing the clock driver?

Regards,
Mike

> 
> > pwm_config()  API could be extended to support
> > not only period [ns] and duty [ns] time
> > but also frequency [Hz] and duty cycle fraction [1/1000?]
> > (instead of time in ns) as parameters.
> > Then  ns (rounded by pwm) to freq. conversion problem
> > inclk_pwm_recalc_rate() usingpwm_get_period()
> > could be avoided.
> > To extend the API pwm_config() can support
> > new flags forduty_ns and period_ns,
> > eg. PWM_DUTY_PERCENT and PWM_PERIOD_HZ.
> 
> Is that rounding really a problem? Also the PWM chips will most likely
> use the concept of period and duty-cycle internally anyway, so it will
> convert back from Hz/percentage to nanoseconds and fall victim to
> similar rounding effects.
> 
> Thierry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/