Re: [PATCH v1 3/5] amd64_edac: enforce synchronous probe

From: Tejun Heo
Date: Sun Sep 28 2014 - 10:41:48 EST


On Fri, Sep 26, 2014 at 02:57:15PM -0700, Luis R. Rodriguez wrote:
...
> [ 14.414746] [<ffffffff814d2cf9>] ? dump_stack+0x41/0x51
> [ 14.414790] [<ffffffff81061972>] ? warn_slowpath_common+0x72/0x90
> [ 14.414834] [<ffffffff810619d7>] ? warn_slowpath_fmt+0x47/0x50
> [ 14.414880] [<ffffffff814d0ac3>] ? printk+0x4f/0x51
> [ 14.414921] [<ffffffff811f8593>] ? kernfs_remove_by_name_ns+0x83/0x90
> [ 14.415000] [<ffffffff8137433d>] ? driver_sysfs_remove+0x1d/0x40
> [ 14.415046] [<ffffffff81374a15>] ? driver_probe_device+0x1d5/0x250
> [ 14.415099] [<ffffffff81374b4b>] ? __driver_attach+0x7b/0x80
> [ 14.415149] [<ffffffff81374ad0>] ? __device_attach+0x40/0x40
> [ 14.415204] [<ffffffff81372a13>] ? bus_for_each_dev+0x53/0x90
> [ 14.415254] [<ffffffff81373913>] ? driver_attach_workfn+0x13/0x80
> [ 14.415298] [<ffffffff81077403>] ? process_one_work+0x143/0x3c0
> [ 14.415342] [<ffffffff81077a44>] ? worker_thread+0x114/0x480
> [ 14.415384] [<ffffffff81077930>] ? rescuer_thread+0x2b0/0x2b0
> [ 14.415427] [<ffffffff8107c261>] ? kthread+0xc1/0xe0
> [ 14.415468] [<ffffffff8107c1a0>] ? kthread_create_on_node+0x170/0x170
> [ 14.415511] [<ffffffff814d883c>] ? ret_from_fork+0x7c/0xb0
> [ 14.415554] [<ffffffff8107c1a0>] ? kthread_create_on_node+0x170/0x170

Do you have CONFIG_FRAME_POINTER turned off? Probe failure itself
aside, the above looks like a bug in really_probe()'s error path. It
looks like it can try to remove sysfs directory that it hasn't added
yet.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/