Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

From: PERIER Romain
Date: Sun Sep 28 2014 - 11:04:32 EST


Well, I will think about it and I will propose a separated patch with
a generic property and helper functions.

2014-09-28 15:25 GMT+02:00 PERIER Romain <romain.perier@xxxxxxxxx>:
> 2014-09-28 14:25 GMT+02:00 Mark Brown <broonie@xxxxxxxxxx>:
>> On Sun, Sep 28, 2014 at 02:00:54PM +0200, PERIER Romain wrote:
>>> 2014-09-28 12:33 GMT+02:00 Mark Brown <broonie@xxxxxxxxxx>:
>>
>>> > We really need to come up with a standard property for this and document
>>> > it rather than continuing to add individual device specific properties
>>> > all doing the same thing, and probably also some helper code and/or a
>>> > standard operation for this - there's a lot of drivers implementing the
>>> > same pattern here.
>>
>>> I completly agree about adding a unified and generic property for that purpose.
>>> I already proposed something for that on devicetree ML, see the thread
>>> "Proposal: generic property for system-power-controller".
>>> Unfortunately I did not get replies :) .
>>
>> Did you CC relevant maintainers and send a patch?
>
> No I did not propose patches as I was an open discussion. Perhaps I
> might propose something as part of my contribution for act8865... (at
> least for the property)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/