Re: [PATCH V5 10/16] perf, core: simplify need branch stack check
From: Peter Zijlstra
Date: Wed Sep 24 2014 - 09:55:26 EST
On Wed, Sep 10, 2014 at 10:09:07AM -0400, kan.liang@xxxxxxxxx wrote:
> From: Kan Liang <kan.liang@xxxxxxxxx>
> event->attr.branch_sample_type is non-zero no matter branch stack
> is enabled explicitly or is enabled implicitly. we can use it to
> replace intel_pmu_needs_lbr_smpl(). This avoids duplicating code
> that implicitly enables the LBR.
Please extend the changelog such that it's obvious this is correct. This
is the second time I've had to look how this works out for PEBS.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/