Re: [PATCH] lib: string.c: Added a funktion function strzcpy
From: Lennart Sorensen
Date: Wed Sep 24 2014 - 10:14:55 EST
On Wed, Sep 24, 2014 at 10:52:06AM +0300, Dan Carpenter wrote:
> On Tue, Sep 23, 2014 at 06:17:53PM -0700, Andi Kleen wrote:
> > Do we really need the bizarre strncpy padding semantics for anything?
> > Why not just use strlcpy?
> We do need the padding in many places to prevent information leaks.
> So we end up open coding the last NUL after so many of the strncpy()
> calls. And we're adding more NUL terminators all over the place now
> just to make the code easier to audit.
I think the suggestion to use strlcpy makes sense too. strlcpy seems
to do exactly what is needed and has a known behaviour already.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/