Re: [PATCH v7 1/3] mfd: devicetree: bindings: Add Qualcomm RPM DT binding
From: Bjorn Andersson
Date: Wed Sep 24 2014 - 11:53:18 EST
On Wed 24 Sep 01:22 PDT 2014, Lee Jones wrote:
> On Mon, 22 Sep 2014, Bjorn Andersson wrote:
> > Add binding for the Qualcomm Resource Power Manager (RPM) found in 8660,
> > 8960 and 8064 based devices. The binding currently describes the rpm
> > itself and the regulator subnodes.
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/mfd/qcom-rpm.txt | 246 ++++++++++++++++++++
> Please adhere to: Documentation/devicetree/bindings/submitting-patches.txt
I assume you mean this part:
1) The Documentation/ portion of the patch should be a separate patch.
But I doubt this document was written with include/dt-bindings in mind, because
in my eyes they are part of "device tree bindings".
> > include/dt-bindings/mfd/qcom-rpm.h | 154 ++++++++++++
> > 2 files changed, 400 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mfd/qcom-rpm.txt
> > create mode 100644 include/dt-bindings/mfd/qcom-rpm.h
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom-rpm.txt b/Documentation/devicetree/bindings/mfd/qcom-rpm.txt
> > new file mode 100644
> > index 0000000..4264021
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/qcom-rpm.txt
> This requires a DT Ack.
> > +++ b/include/dt-bindings/mfd/qcom-rpm.h
> Please split this into a separate patch.
But this is part of the device tree binding and the binding "depends" on it.
> When you do, for this file only, please apply my:
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/