Re: [PATCH v2] pinctrl: qcom: use restart_notifier mechanism for ps_hold
From: Bjorn Andersson
Date: Thu Sep 25 2014 - 20:49:02 EST
On Thu 25 Sep 00:41 PDT 2014, Linus Walleij wrote:
> On Tue, Sep 23, 2014 at 10:59 PM, Josh Cartwright <joshc@xxxxxxxxxxxxxx> wrote:
> > By converting to the restart_notifier mechanism for restart, we allow
> > for other mechanisms, like the watchdog, to be used for restart in the
> > case where PS_HOLD has failed to reset the chip.
> > Since this mechanism may be one of several mechanisms registered, change
> > the post-ps_hold write timeout to be a more reasonable 1 second instead
> > of 10 seconds.
> > Choose priority 128, as according to documentation, this mechanism "is
> > sufficient to restart the entire system".
> > Cc: Pramod Gurav <pramod.gurav@xxxxxxxxxxxxxxx>
> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Tested-by: Pramod Gurav <pramod.gurav@xxxxxxxxxxxxxxx>
> > Signed-off-by: Josh Cartwright <joshc@xxxxxxxxxxxxxx>
> > ---
> > Changes since v1:
> > - Simplified conditional notifier block registration
> > - Reduced wait time to 1s, which I've found to be sufficient on an IFC6410
> > board.
> Björn, are you OK with this patch?
Indeed, this is better than overriding arm_pm_restart.
Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/