Re: [PATCH v2 01/22] PCI/MSI: Clean up struct msi_chip argument
From: Yijing Wang
Date: Thu Sep 25 2014 - 21:59:19 EST
On 2014/9/25 15:15, Thierry Reding wrote:
> On Thu, Sep 25, 2014 at 11:14:11AM +0800, Yijing Wang wrote:
>> Msi_chip functions setup_irq/teardown_irq rarely use msi_chip
> That's not true. Out of the four drivers that you modify two use the
> parameter. And the two that don't probably should be using it too.
> 50% is not "rarely". =)
>> We can look up msi_chip pointer by the device pointer
>> or irq number, so clean up msi_chip argument.
> I don't like this particular change. The idea was to keep the API object
> oriented so that drivers wouldn't have to know where to get the MSI chip
> from. It also makes it more resilient against code reorganizations since
> the core code is the only place that needs to know where to get the chip
Hm, ok, Thomas also don't like this change, I will drop this one, thanks.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/