From: Giuseppe CAVALLARO [mailto:peppe.cavallaro@xxxxxx]
Sent: Wednesday, September 24, 2014 2:10 PM
pass in the priv->stmmac_clk.
Appreciate for the explanation. Just to clarify that I am not asking not to
In fact, the fix will fail at case 2 if driver cannot obtain the priv->stmmac_clk,but just not the case 1.
For case 1, seem like it does not require the stmmac_clk then I thinkthe clk_csr set.
it should be OK not to fail it when driver did not get stmmac_clk but have
ok we can do that but this clock is also managed when the iface is down.
Maybe it could be convenient to manage it for power consumption.
What do you think?
I don't really get what you mean here. Are you telling that you are OK with the fix?
Or you are referring to the bottom idea which introduce clock registration APIs to
Regarding the power management, isn't this taking care by the PCI framework itself
for the PCI devices / PCI cards?
Sorry, may be would need you to provide a big picture to this. Thanks. :)
Anyway, I can change the fix by adding the clock registration APIswould need you guys to provide me information on other platforms about
being call at the stmmac_pci.c probe there before calling
stmmac_dvr_probe. By doing this, it created a dependency to the pci
driver that must have CONFIG_HAVE_CLK to be turned on. Besides, I
what is the best value to set? Can I just set to zero since the stmmac_pci
driver is always using the priv->plat->clk_csr?