Re: [PATCH v4 1/2] perf tool: encapsulate dsos list head into struct dsos

From: Arnaldo Carvalho de Melo
Date: Fri Sep 26 2014 - 10:12:41 EST

Em Wed, Sep 24, 2014 at 11:45:39AM -0400, Waiman Long escreveu:
> This is a precursor patch to enable long name searching of DSOs
> using the rbtree. In this patch, a new dsos structure is created
> which contains only a list head structure for the moment. The new
> dsos structure is used, in turn, in the machine structure for the
> user_dsos and kernel_dsos fields. Only the following 3 dsos functions
> are modified to accept the new dsos structure parameter instead
> of list_head:
> - dsos__add()
> - dsos__find()
> - __dsos__findnew()
> Because of the need to find out the corresponding dsos structure to
> properly call dsos__add() in dso__load_sym() of util/symbol-elf.c,
> a new dsos field is also added to the dso structure.

What tree did you use to produce these patches? I just tried on my
perf/core branch and I get some fuzzes:

[acme@zoo linux]$ patch -p1 < /wb/1.patch
patching file tools/perf/util/dso.c
Hunk #1 succeeded at 755 (offset 2 lines).
Hunk #2 succeeded at 852 (offset 2 lines).
patching file tools/perf/util/dso.h
patching file tools/perf/util/header.c
patching file tools/perf/util/machine.c
Hunk #2 succeeded at 72 (offset 2 lines).
Hunk #3 succeeded at 477 (offset 29 lines).
Hunk #4 succeeded at 994 (offset 29 lines).
patching file tools/perf/util/machine.h
Hunk #2 succeeded at 39 with fuzz 1 (offset 1 line).
patching file tools/perf/util/probe-event.c
patching file tools/perf/util/symbol-elf.c
Hunk #1 succeeded at 929 (offset 13 lines).
[acme@zoo linux]$

I'll fix this up, probably harmless, just a heads up.

- Arnaldo
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at