Re: [PATCH 1/2] arm, fbdev, omap2, LLVMLinux: Remove nested function from omap2 dss

From: Behan Webster
Date: Sat Sep 27 2014 - 18:54:25 EST

On 09/27/14 09:46, Felipe Balbi wrote:
On Fri, Sep 26, 2014 at 06:10:52PM -0700, Behan Webster wrote:
Replace the use of nested functions where a normal function will suffice.

Nested functions are not liked by upstream kernel developers in general. Their
use breaks the use of clang as a compiler, and doesn't make the code any

This code now works for both gcc and clang.

Signed-off-by: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>
Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
Cc: Arnd Bergmann <arnd@xxxxxxxx>
another one that make sense :-) And probably also deserves
Indeed! That would be very appreciated.

The clang static analyzer already points this one out. :)


Behan Webster

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at