Re: [PATCH] of: correct of_console_check()'s return value
From: Grant Likely
Date: Sun Sep 28 2014 - 04:56:46 EST
On Fri, Sep 26, 2014 at 12:53 AM, Brian Norris
> Hi Grant,
> On Mon, Sep 08, 2014 at 11:42:38AM +0100, Grant Likely wrote:
>> On Wed, 3 Sep 2014 11:06:43 -0700, Brian Norris <computersforpeace@xxxxxxxxx> wrote:
>> > The comments above of_console_check() say that it will return TRUE if it
>> > registers a preferred console, but add_preferred_console() uses a
>> > 0-equals-success convention, so ths leaves of_console_check() with an
>> > inconsistent policy for its return values.
>> > Fortunately, nobody was actually checking the return value of
>> > of_console_check(), so this isn't significant at the moment.
>> > But let's match the comments, so we're doing what we say.
>> > Fixes: 3482f2c52b77 ('of: Create of_console_check() for selecting a console specified in /chosen')
>> > Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx>
>> > Cc: Grant Likely <grant.likely@xxxxxxxxxx>
>> Good catch. Applied, thanks.
> Applied to what? I don't see it in linux-next.
It got merged into mainline on Thursday.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/