Re: [PATCH] MIPS: R3000: Fix debug output for Virtual page number
From: Maciej W. Rozycki
Date: Sun Sep 28 2014 - 20:53:28 EST
On Wed, 10 Sep 2014, Isamu Mogi wrote:
> Virtual page number of R3000 in entryhi is 20 bit from MSB. But in
> dump_tlb(), the bit mask to read it from entryhi is 19 bit (0xffffe000).
> The patch fixes that to 0xfffff000.
> Signed-off-by: Isamu Mogi <isamu@xxxxxxxxxxxx>
Acked-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>
It would be good to add appropriate macros to <asm/mipsregs.h> too, to
avoid magic numbers and decrease the likelihood of issues like this. As a
separate change, that is, of course, and not a prerequisite.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/