Re: [PATCH v3 1/3] cap11xx: make driver generic for variant support
From: Matt Ranostay
Date: Sun Sep 28 2014 - 22:45:36 EST
On Sat, Sep 27, 2014 at 11:21 AM, Daniel Mack <daniel@xxxxxxxxxx> wrote:
> On 09/25/2014 07:24 AM, Matt Ranostay wrote:
>> cap1106 driver can support much more one device make the driver
>> generic for support of similiar parts.
>> Signed-off-by: Matt Ranostay <mranostay@xxxxxxxxx>
>> .../devicetree/bindings/input/cap1106.txt | 53 ----
>> .../devicetree/bindings/input/cap11xx.txt | 54 ++++
>> drivers/input/keyboard/Kconfig | 8 +-
>> drivers/input/keyboard/Makefile | 2 +-
>> drivers/input/keyboard/cap1106.c | 341 ---------------------
>> drivers/input/keyboard/cap11xx.c | 340 ++++++++++++++++++++
>> 6 files changed, 399 insertions(+), 399 deletions(-)
> As I've said, such a patch is really a whole lot more readable if you
> use the -M switch for git format-patch to detect renames.
TIL I learned of new git format-patch option. Will resubmit v4.
> Other than that, the series now looks good to me. I can't test it,
> however, as I don't have access to the hardware anymore.
Yeah I can't confirm it works on cap1106 but there is no reason it
Cap1188 works as expected.
> Reviewed-by: Daniel Mack <daniel@xxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/