Re: [PATCH] Revert "xen/acpi-processor: fix enabling interrupts on syscore_resume"

From: Konrad Rzeszutek Wilk
Date: Mon Sep 29 2014 - 13:55:36 EST

On Mon, Sep 29, 2014 at 03:56:14PM +0100, David Vrabel wrote:
> On 29/09/14 15:51, Konrad Rzeszutek Wilk wrote:
> > This reverts commit cd979883b9ede90643e019f33cb317933eb867b4.
> >
> > As it actually never gets called on the initial domain when
> > resuming. That is after we suspend and go in resume, the
> > do_suspend (from manage.c) is never called (it is if it
> > was running as a guest)- so the 'resume' functionality of the driver
> > was never called.
> >
> > Which means that this whole patch was pointless (well, it did
> > remove the WARNING splat).
> >
> > This patch reverts the patch and allows the C and P states to
> > be uploaded to the hypervisor on ACPI S3 resume of the
> > initial domain. It sadly brings back the WARNING splat which
> > will have to be dealt with at some point.
> Incorrectly enabling interrupts in contexts where this is not permitted
> is not just harmless "WARNING splat".
> This has been broken since 3.15-rc1 without anyone else noticing so I
> think we can afford to take a bit more time and fix the original bug
> properly.

This patch should be a good start to discussing the fix.