Re: [PATCH] regmap: Allow read_reg_mask to be 0

From: Lars-Peter Clausen
Date: Tue Sep 30 2014 - 17:03:50 EST

On 09/30/2014 06:07 PM, Dan Murphy wrote:
There may be spi devices that do not require a
register read mask to read the registers.

Currently the code sets the read mask based on
a non-zero value passed in from the driver or if that
value is 0 sets the read mask to 0x80.

It only sets it to the bus default if both read_flag_mask and write_flag_mask are 0. The assumption is that both of them being zero is a invalid configuration and either of them (or both) have to be non-zero for proper operation, since otherwise the device can't tell the difference between a read and a write.

Do you have a device where both the read and the write mask is 0?

- Lars
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at