Re: [PATCH/RFC v2 1/4] ARM: hw_breakpoint: Add arm_dbg_regs_available flag

[Geert Uytterhoeven]

Hi Will,

On Tue, Sep 30, 2014 at 6:03 PM, Will Deacon <will.deacon@xxxxxxx> wrote:
> On Tue, Sep 30, 2014 at 01:26:24PM +0100, Geert Uytterhoeven wrote:
>> If power area D4, which contains the Coresight-ETM hardware block, is
>> powered down on R-Mobile A1 (r8a7740), the kernel crashes when
>> suspending from s2ram with:
>>
>>     Internal error: Oops - undefined instruction: 0 [#1] ARM
>>
>> This happens because dbg_cpu_pm_notify() calls reset_ctrl_regs(), which
>> can't access the debug registers as the debug module is powered down.
>>
>> As suggested by Russell King, track whether the ETM block is powered down
>> to fix this.
>>
>> The availability of the debug registers depends on the platform and its
>> state.  Hence provide a mechanism for platform code to indicate that the
>> debug registers are available or not, using a boolean flag that defaults
>> to true.

> Whilst I guess this solves your problem, it doesn't feel like a scalable fix
> for something that can/will assumedly happen elsewhere in an SoC (e.g. PMU
> registers in perf). I'd much rather have a generic abstraction for power
> domains, which subsystems such as hw_breakpoint can attempt to take a
> reference on when they want to access registers in that domain.

I agree this is a bit hackish, and not a long-term solution.

As soon as the ARM debug/perf subsystem starts using devices instantiated
from DT, implementing PM runtime support, this will work out-of-the-box.
Until then, we cannot have proper support for the D4 PM domain on R-Mobile
SoCs, without hacks like this (or like never powering down the D4 PM domain
--- perhaps that's the way to go).

I believe Mathieu is working on the former, but so far without converting
hw_breakpoint.c nor adding PM runtime support?

Thanks for your understanding!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/