Re: [PATCH v6 2/2] drm/i2c:tda998x: Use the HDMI audio CODEC

From: Jean-Francois Moine
Date: Wed Oct 01 2014 - 05:28:45 EST


On Tue, 30 Sep 2014 20:25:40 +0100
Mark Brown <broonie@xxxxxxxxxx> wrote:

> > + request_module("snd-soc-hdmi-codec");
> > + pdev = platform_device_register_resndata(&priv->hdmi->dev,
> > + "hdmi-audio-codec",
> > + PLATFORM_DEVID_NONE,
> > + NULL, 0,
> > + &tda998x_hdmi_data,
> > + sizeof tda998x_hdmi_data);
>
> Why is this request_module() needed? If there is a good reason for it
> we should have some documentation.

The reason is simple: as the HDMI CODEC is not declared in the DT, the
associated module must be loaded in memory.

--
Ken ar c'hentaà | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/