Re: [PATCH] vfio/pci: Add missing linux/irq.h include

From: Alex Williamson
Date: Wed Oct 01 2014 - 13:14:34 EST


On Wed, 2014-10-01 at 14:00 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> This code uses the irq_get_msi_desc() function whose prototype is in
> linux/irq.h. Include this header to fix a build failure.
>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
> drivers/vfio/pci/vfio_pci_intrs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
> index a068bb0d69e5..d6f097b0e0e3 100644
> --- a/drivers/vfio/pci/vfio_pci_intrs.c
> +++ b/drivers/vfio/pci/vfio_pci_intrs.c
> @@ -15,6 +15,7 @@
>
> #include <linux/device.h>
> #include <linux/interrupt.h>
> +#include <linux/irq.h>
> #include <linux/eventfd.h>
> #include <linux/msi.h>
> #include <linux/pci.h>

Hi Thierry, thanks for the patch. The call to irq_get_msi_desc()
actually came in as part of a conflict resolution in the next tree.
I've requested that the next spin of linux-next include this header if
the conflict still exists, but I'm also working to make the conflict go
away along with the function call that requires this additional header.
Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/