Re: [PATCH] HID: uHID: fix excepted report type

From: Jiri Kosina
Date: Wed Oct 01 2014 - 15:02:00 EST


On Wed, 1 Oct 2014, David Herrmann wrote:

> > diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
> > index f6ec5ea..e094c57 100644
> > --- a/drivers/hid/uhid.c
> > +++ b/drivers/hid/uhid.c
> > @@ -154,7 +154,7 @@ static int __uhid_report_queue_and_wait(struct uhid_device *uhid,
> >
> > spin_lock_irqsave(&uhid->qlock, flags);
> > *report_id = ++uhid->report_id;
> > - uhid->report_type = ev->type;
> > + uhid->report_type = ev->type + 1;
>
> Nice catch. We always need the *_REPLY type as response:
>
> Reviewed-by: David Herrmann <dh.herrmann@xxxxxxxxx>

Applied, thanks.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/