Re: [PATCH 1/3] mm: generalize VM_BUG_ON() macros

[Andrew Morton]

On Wed,  1 Oct 2014 14:31:59 +0300 "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx> wrote:

> This patch makes VM_BUG_ON() to accept one to three arguments after the
> condition. Any of these arguments can be page, vma or mm. VM_BUG_ON()
> will dump info about the argument using appropriate dump_* function.
> 
> It's intended to replace separate VM_BUG_ON_PAGE(), VM_BUG_ON_VMA(),
> VM_BUG_ON_MM() and allows additional use-cases like:
> 
>   VM_BUG_ON(cond, vma, page);
>   VM_BUG_ON(cond, vma, src_page, dst_page);
>   VM_BUG_ON(cond, mm, src_vma, dst_vma);
>   ...

I can't say I'm a fan of this.  We don't do this sort of thing anywhere
else in the kernel and passing different types to the same thing in
different places is unusual and exceptional.  We gain very little from
this so why bother?

Adding new printk(%p) thingies for vmas and pages would be more
consistent but still of dubious value.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/