Re: [PATCH] mm, compaction: using uninitialized_var insteads setting 'flags' to 0 directly.

[David Rientjes]

On Tue, 30 Sep 2014, Vlastimil Babka wrote:

> On 09/29/2014 05:30 AM, Xiubo Li wrote:
> > Setting 'flags' to zero will be certainly a misleading way to avoid
> > warning of 'flags' may be used uninitialized. uninitialized_var is
> > a correct way because the warning is a false possitive.
> 
> Agree.
> 
> > Signed-off-by: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx>
> 
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> 

I thought we just discussed this when 
mm-compaction-fix-warning-of-flags-may-be-used-uninitialized.patch was 
merged and, although I liked it, it was stated that we shouldn't add any 
new users of uninitialized_var().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/