Re: [PATCH] sched: Use RCU read lock on all calls to dl_bw_of()

From: Peter Zijlstra
Date: Thu Oct 02 2014 - 05:24:40 EST


On Tue, Sep 30, 2014 at 12:23:37PM +0400, Kirill Tkhai wrote:
> [PATCH]sched: Use dl_bw_of() under preempt_disable()
>
> rq->rd is freed using call_rcu_sched(), so rcu_read_lock() to access it
> is not enough. We should use either rcu_read_lock_sched() or preempt_disable().
>
> We choose preempt_disable()/preempt_enable() like in other places
> where rq->rd is used.

I changed it to rcu_read_lock_sched(), but no biggie, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/