Re: [PATCH 2/4] UBI: Fastmap: Calc fastmap size correctly

From: Richard Weinberger
Date: Thu Oct 02 2014 - 09:18:13 EST


Am 02.10.2014 15:14, schrieb Tanya Brokhman:
> On 9/30/2014 1:20 AM, Richard Weinberger wrote:
>> We need to add fm_sb too.
>>
>> Signed-off-by: Richard Weinberger <richard@xxxxxx>
>> ---
>> drivers/mtd/ubi/fastmap.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
>> index 0431b46..2b0d8d6 100644
>> --- a/drivers/mtd/ubi/fastmap.c
>> +++ b/drivers/mtd/ubi/fastmap.c
>> @@ -24,7 +24,8 @@ size_t ubi_calc_fm_size(struct ubi_device *ubi)
>> {
>> size_t size;
>>
>> - size = sizeof(struct ubi_fm_hdr) + \
>> + size = sizeof(struct ubi_fm_sb) + \
>> + sizeof(struct ubi_fm_hdr) + \
>> sizeof(struct ubi_fm_scan_pool) + \
>> sizeof(struct ubi_fm_scan_pool) + \
>> (ubi->peb_count * sizeof(struct ubi_fm_ec)) + \
>>
>
> Not sure what's the proper way doing this (Reviewed-by/Acked-by) but I agree this patch is required. I would just elaborate a bit more on the commit message.

If you read this patch and find it good, please add your Reviewed-by.
Thanks a lot for reviewing my patches!

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/